Added Result<SupportedI/OConfigs, DeviceError> to handle Errors better #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix WASAPI Host warnings: Added Stream and impl handling of input/output error configs to return Result<SupportedI/OConfigs, DeviceError> for better user experience and better error handling Before: warning: unused import: `crate::SupportedStreamConfigsError` --> src\host\wasapi\mod.rs:11:5 | 11 | use crate::SupportedStreamConfigsError; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I-Ruiz
changed the title
I-Ruiz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed it because of the compile warning.
Fix WASAPI Host warnings: Added Stream and impl handling of input/output error configs to return
Result<SupportedI/OConfigs, DeviceError>
for better user experience and better error handling
Fixes #740 Respect Windows output device selection
By Erroring and finding new I/O Config
(if WASAPI)
Current behavior
I am using rodio to play audio on Windows 11. When I change the output device on Windows, the audio continues to play on the old device.
//////Another Error //////////
FIxes #426 Panic in stream.rs:145:9 (unwrap Err) on Stream drop when device disconnected
On Windows, presumably using WASAPI, since I don't have ASIO installed.
To reproduce:
Create stream.
Disconnect the audio device, and properly get a DeviceNotAvailable error callback (created with device.build_output_stream(...)).
Drop stream.